Configurable "Mark As Success" button for custom shell script steps
pending feedback
P
Pink Ox
Context
Right now a harness user can click a button MARK_AS_FAILURE for a step which is currently under execution. This allows the user to stop the execution for a step whenever required.
Requirement
- We want a step level MARK_AS_SUCCESS button to mark an executing step as success, similar to the mark as failure button for custom shell script step.
- Currently, Harness does support mark as success, but that is only part of failure strategy and becomes applicable once a step is failed. Our requirement is to mark a step as success, while the step execution is in progress.
Expected Behaviour
- Even though the step is executing some script, clicking on the MARK_AS_SUCCESS button should abort the step execution -> mark the step as success -> move ahead to execute the next step.
- The step which is marked as success it should have clear indication showing this is marked as success mid execution, by which user and at what time. This indication should be different from how harness currently shows mark as success as part of failure strategy after a step is failed.
Where should this configuration exist?
This can be a step-level configuration, a Yes/No button while configuring a step.
Log In
Rohan Gupta
pending feedback
Rohan Gupta
Why cant you leverage the Manual Intervention functionality? It exposes the Mark as success or failure functionality. Is the difference here that you want to just skip the step and move on? Then maybe Mark as Success Button may be not the right use case to solve this? The behavior doesn't align with Mark as Success.
P
Pink Ox
Rohan Gupta
Q: Why can't you leverage the Manual Intervention functionality?
Ans:
while a step is under execution, manual Intervention is only possible if I want to mark the step as failure. But to consider the step as success and move ahead -> not doable now on harness.
Q: Is the difference here that you want to just skip the step and move on?
Ans: Yes,
we want to skip the step undergoing execution -> consider the step as a success -> move ahead to execute the next step in the pipeline
Q: Why this is a requirement?
Ans:
- Suppose a user is running custom tests using shell script and after some time the user reaches the conclusion that the step execution is no longer required after some observation.
- Then it doesn’t make sense to make the pipeline wait, till the execution is complete or get timeout. We simply want to allow the user to mark the shell script step as success and move ahead with the execution. There can be many other scenarios apart from tests, where this can be useful.
Qn: The behaviour doesn't align with Mark as Success.
Ans: We are open to having a different term other than "mark as success" to keep a clear distinction between manual intervention after a step failure and manual intervention while step is under execution.