Cancelling a Drone job sends a SIGKILL
pending feedback
I
Impressive Limpet
Drone appears to send a SIGKILL to containers when a build is cancelled. This means that processes are unable to terminate cleanly. so user wanted that be changed to send a SIGTERM instead so that processes can handle it and terminate cleanly.The SIGKILL could be sent if containers are still running after a certain timeout.
Log In
Canny AI
Merged in a post:
configurable signals on drone-runner-docker
I
Iron grey Cuckoo
I saw Brad opened this draft PR: https://github.com/drone-runners/drone-runner-docker/pull/72
What would it take for you guys to release that soon-ish? We're making heavier use of promote pipelines for deployments, and that use case very much benefits from being able to perform clean-up logic and provide feedback to developers when builds get canceled. SIGKILL does not currently allow for that.
N
Nofar Bluestein
pending feedback
N
Nofar Bluestein
Hey, thank you for your feedback. could you please elaborate on the use case? CI containers are expected to be ephemeral and not long-running. Would be good to understand the use case better. Thank you